tadeja commented on code in PR #51280:
URL: https://github.com/apache/arrow/pull/51280#discussion_r4134121164
##########
ci/scripts/cpp_test.sh:
##########
@@ -143,15 +143,26 @@ if [ "${ARROW_USE_MESON:-OFF}" = "OFF" ] && \
# Search vcpkg before <prefix>/lib/cmake.
CMAKE_PREFIX_PATH="${VCPKG_ROOT}/installed/${VCPKG_DEFAULT_TRIPLET};${CMAKE_PREFIX_PATH}"
fi
+ ARROW_EXAMPLE_S3="${ARROW_S3:-OFF}"
+ if [ "${ARROW_ENABLE_THREADING:-ON}" = "OFF" ]; then
+ ARROW_EXAMPLE_S3=OFF
+ fi
Review Comment:
Actually, I've just moved that no-threading guard to a better, earlier check
- b66bc87
Thanks, @raulcd, for the very good question!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
