kou commented on code in PR #51610:
URL: https://github.com/apache/arrow/pull/51610#discussion_r4127214240
##########
.github/workflows/cpp_windows.yml:
##########
@@ -115,12 +115,17 @@ jobs:
with:
path: ${{ steps.ccache-info.outputs.cache-dir }}
key: cpp-ccache-windows-${{ inputs.arch }}
+ - name: Find Visual Studio
+ shell: bash
+ run: |
+ vs_path=$("/c/Program Files (x86)/Microsoft Visual
Studio/Installer/vswhere.exe" -latest -property installationPath)
+ echo "VS_INSTALL_PATH=${vs_path}" >> "${GITHUB_ENV}"
Review Comment:
We may be able to simplify this:
```suggestion
shell: pwsh
run: |
"VS_INSTALL_PATH=$(vswhere -latest -property installationPath)" >>
$env:GITHUB_ENV
```
##########
.github/workflows/cpp_windows.yml:
##########
@@ -115,12 +115,17 @@ jobs:
with:
path: ${{ steps.ccache-info.outputs.cache-dir }}
key: cpp-ccache-windows-${{ inputs.arch }}
+ - name: Find Visual Studio
+ shell: bash
+ run: |
+ vs_path=$("/c/Program Files (x86)/Microsoft Visual
Studio/Installer/vswhere.exe" -latest -property installationPath)
+ echo "VS_INSTALL_PATH=${vs_path}" >> "${GITHUB_ENV}"
- name: Build
shell: cmd
env:
VCVARS_ARCH: ${{ inputs.arch }}
run: |
- call "C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" %VCVARS_ARCH%
Review Comment:
Let's do it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
