divjotarora commented on code in PR #50909:
URL: https://github.com/apache/arrow/pull/50909#discussion_r4131691976
##########
cpp/src/parquet/schema.h:
##########
@@ -199,6 +200,8 @@ using NodeVector = std::vector<NodePtr>;
class PARQUET_EXPORT PrimitiveNode : public Node {
public:
static std::unique_ptr<Node> FromParquet(const void* opaque_element);
+ static std::unique_ptr<Node> FromParquet(const void* opaque_element,
+ const SchemaPath* parent_path);
Review Comment:
I added this so `Unflatten` could call it. Maybe let's resolve the logging
discussion first as this function is only needed to do the logging?
##########
cpp/src/parquet/schema.cc:
##########
@@ -453,10 +453,21 @@ std::unique_ptr<Node> PrimitiveNode::FromParquet(const
void* opaque_element) {
std::unique_ptr<PrimitiveNode> primitive_node;
if (element->__isset.logicalType) {
// updated writer with logical type present
- primitive_node = std::unique_ptr<PrimitiveNode>(
- new PrimitiveNode(element->name,
LoadEnumSafe(&element->repetition_type),
- LogicalType::FromThrift(element->logicalType),
- LoadEnumSafe(&element->type), element->type_length,
field_id));
+ auto physical_type = LoadEnumSafe(&element->type);
+ auto logical_type = LogicalType::FromThrift(element->logicalType);
+ // Tolerate unrecognized logical/physical type combinations by dropping
the logical
+ // type annotation.
+ if (logical_type &&
+ !logical_type->is_applicable(physical_type, element->type_length)) {
+ ARROW_LOG(WARNING) << "Dropping unsupported logical type "
Review Comment:
@emkornfield @wgtmac Any thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
