divjotarora commented on code in PR #50909:
URL: https://github.com/apache/arrow/pull/50909#discussion_r4131725675
##########
cpp/src/parquet/schema.h:
##########
@@ -199,6 +200,8 @@ using NodeVector = std::vector<NodePtr>;
class PARQUET_EXPORT PrimitiveNode : public Node {
public:
static std::unique_ptr<Node> FromParquet(const void* opaque_element);
+ static std::unique_ptr<Node> FromParquet(const void* opaque_element,
+ const SchemaPath* parent_path);
Review Comment:
If we decide to keep the logging, we could make this new overload private
but still accessible from `Unflatten`:
```
PARQUET_EXPORT friend std::unique_ptr<Node> Unflatten(
std::span<const format::SchemaElement> elements, int max_depth);
```
Let me know if you'd prefer this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
