alamb commented on PR #48345: URL: https://github.com/apache/arrow/pull/48345#issuecomment-5898650150
I went over this PRs comments again and I can't see any additional outstanding items. Are we waiting on anything else to approve this PR? (perhaps @HuaHuaY or @wgtmac could comment as they are listed as code owners and have reviewed this PR before) One thing I did find was @emkornfield 's suggestion to > I think the one other thing we should figure out is how to fall back to plain encoding at some point if ALP is completely failing on the dataset (i.e. it is consistently adding pages that take more space the PLAIN encoding). I think this can be done in a follow-up. Maybe that would be good to file a follow on ticket -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
