wgtmac commented on code in PR #48345: URL: https://github.com/apache/arrow/pull/48345#discussion_r3986558782
########## cpp/src/arrow/util/alp/alp_constants_internal.h: ########## @@ -0,0 +1,288 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// Constants and type traits for ALP (Adaptive Lossless floating-Point) compression. +// Spec: https://github.com/apache/parquet-format/blob/master/Encodings.md#alp + +#pragma once + +#include <cstdint> + +#include "arrow/util/logging.h" + +namespace arrow::util::alp { + +// ---------------------------------------------------------------------- +// AlpConstants + +/// \brief Constants for Adaptive Lossless floating-Point (ALP) compression +/// See: https://github.com/apache/parquet-format/blob/master/Encodings.md#alp +class AlpConstants { + public: + /// Default number of elements compressed together as a unit. + /// The format supports arbitrary power-of-2 sizes via log_vector_size in the Review Comment: This is just my personal preference that these comments are a little bit verbose since we have already referenced the Parquet spec for ALP. This applies to similar comments across files added in the arrow/util/alp directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
