Jefffrey commented on code in PR #11209:
URL: https://github.com/apache/arrow-rs/pull/11209#discussion_r4145512124
##########
arrow-data/src/transform/mod.rs:
##########
@@ -843,6 +843,16 @@ impl<'a> MutableArrayData<'a> {
));
}
+ if len == 0 {
+ return Ok(());
+ }
+
+ if matches!(&self.data.data_type, DataType::Union(fields, _) if
fields.is_empty()) {
Review Comment:
if this is meant to avoid dirtying the state on error, we might be better
off with an approach where we try to recover the state on failure or perhaps
modify the state only after calling `extend_nulls`, to try stay consistent with
the other methods (e.g. `extend_nulls` for run arrays can also error) and avoid
duplicating these error checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
