kou commented on issue #51690: URL: https://github.com/apache/arrow/issues/51690#issuecomment-5962296474
I think that this is not a blocker. It seems that https://github.com/apache/arrow/blob/e85e181188ac3c5e8407b2160331faf5e78fd429/cpp/cmake_modules/SetupCxxFlags.cmake#L56 introduced by https://github.com/apache/arrow/pull/46963 is the cause of this. It's already included in our past releases. We can fix it in the next release. BTW, I feel that the approach used by #46963 is not a good approach because it always defines `__*__` globally by `add_definitions()` (other SIMD related flags cares about `ARROW_SIMD_LEVEL`) and we should not define `__*__` macros as much as possible (I think that https://github.com/simdjson/simdjson/issues/2864#issuecomment-5716211702 is correct). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
