etseidl commented on code in PR #11262:
URL: https://github.com/apache/arrow-rs/pull/11262#discussion_r4170518834


##########
parquet/src/arrow/array_reader/byte_array_dictionary.rs:
##########
@@ -295,6 +297,8 @@ struct DictionaryDecoder<K, V> {
 
     value_type: ArrowType,
 
+    fixed: Option<ColumnDescPtr>,

Review Comment:
   nit: I know it's set 27 lines down, but it would be nice to document here 
that this is a sentinel that's only `Some` for FLBA columns. Or name it 
`flba_column_descr` or something. Or both 😉 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to