HippoBaro commented on PR #11262: URL: https://github.com/apache/arrow-rs/pull/11262#issuecomment-5965470822
> One last thought...it would be nice to log a warning when legacy is detected. Agreed in principle. The crate currently depends on neither `log` nor `tracing`, though, and I couldn’t find any existing use of `stdout` or `stderr` either. I’d be hesitant to introduce a logging dependency or start printing directly. Seems like the wrong way to do it? > the idea makes sense to me, I didnt take too close of a look but are there benchmarks that show the improvement here? This is a bug fix and isn’t expected to affect performance. I suppose routing FLBA dictionary inputs through the writer encoder backend could have some performance impact, but even if it turns out to be a net negative, correctness comes first. I’ll run the benchmarks to quantify it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
