miguelcorderopamphile commented on PR #11315: URL: https://github.com/apache/arrow-rs/pull/11315#issuecomment-5981111948
Thanks for the review. Addressed all points: reused `wrapping_pow` for the powers of two, switched the random values to the existing `rand` dependency (seeded `StdRng` for determinism), renamed the oracle test (`to_string().parse::<f64>()` is a correctly rounded decimal-to-binary oracle), and expanded the comments on the sticky bit and the midpoint. Pushed in `61b6d43f0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
