miguelcorderopamphile commented on PR #11315: URL: https://github.com/apache/arrow-rs/pull/11315#issuecomment-5989032617
Applied all three points in 9c6987462: 1. The midpoint comment now explains the rationale instead of restating the formula: binary64 has a 53-bit significand, so adjacent values inside `[2^e, 2^(e+1))` are `2^(e-52)` apart and the exact tie sits at `2^(e-53)` above `2^e`; the sweep starts at 53 (below that the midpoint is not an integer) and ends at 254 (`2^255` overflows `i256`). 2. Renamed the test to `test_i256_to_f64_fuzz`. 3. Simplified the seed to `StdRng::seed_from_u64(42)`. Local checks: `cargo fmt --all -- --check`, `cargo test -p arrow-buffer test_i256_to_f64` (both tests pass), `cargo clippy -p arrow-buffer --all-targets -- -D warnings` clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
