anandghegde commented on PR #11076:
URL: https://github.com/apache/arrow-rs/pull/11076#issuecomment-6014381335
Yes, there is a human here 🙋♂️ , sorry.
I opened four PRs on 13 September for issue #11032. All four move code out of
the same file, `cast/mod.rs`. Each merge-up then made fresh conflicts in the
other three. The result was a queue of repetitive merge work.
I handed that merge work, and some of these replies, to an AI tool. I did not
review the output before I pushed the same. That one decision caused every
problem that you found:
- The merge-up on #11076 reverted the changes from #11242.
- I made the code change that you asked for, but I left the merge conflict as
it was.
- On #11078 I posted a reply about a change, but no commit existed.
You spent your time on slop that i should have reviewed before pushing.
Now coming to the state of the PRs -
I did not resolve the conflicts by hand. Upstream had changed several of the
functions that move. This includes the integer-to-decimal cast optimisation
and
the decimal-to-float rounding correction. A manual resolution can revert
those
changes silently. So I rebuilt both extractions on the current `main`
instead.
Both branches now only move the existing code into the new module, without
changing its logic or behavior.
- The moved text is identical to the text that came out of `cast/mod.rs`.
- The only other changes are the `mod` lines, the `use` lines, and the
visibility that the child module needs.
Going forward, i will -
- **One PR at a time** when the PRs touch the same file. I will not open a
parallel queue again.
- I shall read every diff and every comment myself before I push or post the
same.
Hope this clarifies. Thanks for your patience, and sorry once again for the
wasted review cycles. In case this PR has already taken more of your review
time than
the change is worth, I am okay if you close it. I shall not feel bad about
the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
