alamb commented on PR #11076: URL: https://github.com/apache/arrow-rs/pull/11076#issuecomment-6039714904
> I shall read every diff and every comment myself before I push or post the This will be most appreciated 🙏 > You spent your time on slop that i should have reviewed before pushing. I think the point here is that the most value you can add, as an author, is to make it easy to understand your propsoed changes to others (aka us as reviewers) so we can get the changes in efficiently The more concise / easier to understand what you are doing here the better. For example, the details of what you had to do to resolve the merge conflict in English prose is not very helpful (how does it help us determine if we should merge this PR?) > Upstream had changed several of the > functions that move. This includes the integer-to-decimal cast optimisation and > the decimal-to-float rounding correction. A manual resolution can revert those > changes silently. So I rebuilt both extractions on the current main instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
