rok commented on PR #51680: URL: https://github.com/apache/arrow/pull/51680#issuecomment-6014114556
To be more explicit, if we use auto-generated-stubs-from-cython we can proceed like so: 1. auto-generate the stubs for the cython and python surface with stubgen-pyx 1. cover the dynamically generated surface (kernels) with manual stubs 1. enrich auto-generated cython/ptyhon stubs Both dynamic and cython/python stubs will be included into git without docstrings (we agreed on this somewhere in or in vicinity of https://github.com/apache/arrow/issues/32609). We will want to use our [existing docstring populating script](https://github.com/apache/arrow/blob/main/python/scripts/update_stub_docstrings.py) or `docstring-adder` to inject docstrings into stubs at wheel build time. What I'm a little worried about is potential namespaces (dynamic, cython and python) overlap which might require extra logic. If this logic gets too complex I would be against using the mix of auto-generated and manual stubs (and slightly prefer manual-only). This would be to keep maintenance cost of stubs as low as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
