adriangb commented on PR #10555: URL: https://github.com/apache/arrow-rs/pull/10555#issuecomment-6044289322
Thank you @alamb for the careful review. I know this code is hard to verify, your incredible attention to detail is invaluable. I filed issues for the open follow-ups from this review: - https://github.com/apache/arrow-rs/issues/11429: the predicate stage projection should have one source, `ColumnFetch` should fetch pages by index, and there are test and benchmark gaps (@viirya) - https://github.com/apache/arrow-rs/issues/11430: with a `RowFilter`, `LIMIT` does not shorten the plan (@viirya) - https://github.com/apache/arrow-rs/issues/11431: document the read-ahead buffering contract, and deprecate `is_at_row_group_boundary` / `row_groups_remaining` (@viirya, @alamb) https://github.com/apache/arrow-rs/issues/11428 already tracks the duplicated logic in the planner and the decoder. https://github.com/apache/arrow-rs/pull/11393 removes the placeholder `StageSchedule`. I will help to work through these followups 🙏🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
