alamb commented on PR #10555: URL: https://github.com/apache/arrow-rs/pull/10555#issuecomment-6044079451
I'll plan to merge this tomorrow unless anyone wants more time to review Thank you @HippoBaro and @viirya for the reviews I filed a ticket to try and consolidate the planning logic as I am very worried about the long term maintenance / understandability of splitting the ScanPlan and actual reader logic - https://github.com/apache/arrow-rs/issues/11428 I also can help shake the feeling that the current structure is now more complicated than the problem that it is trying to solve -- and that the PushDecoder has exceeeded my ability to understand the code anymore. So basically this is a plean to help try and simplify before we embark on the next big refactor (aka incrementally decoding row groups..) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
