Jefffrey commented on code in PR #11497:
URL: https://github.com/apache/arrow-rs/pull/11497#discussion_r4243208665
##########
.github/workflows/dev.yml:
##########
@@ -25,17 +25,17 @@ permissions:
contents: read
jobs:
- rat:
- name: Release Audit Tool (RAT)
+ license-headers:
+ name: License headers
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 #
v7.0.1
- - name: Setup Python
- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 #
v7.0.0
+ - name: Install HawkEye
+ uses: taiki-e/install-action@861a07ce7084f55488e375df125cdc99bba60eb7
# v2.87.23
with:
- python-version: 3.8
- - name: Audit licenses
- run: ./dev/release/run-rat.sh .
+ tool: [email protected]
Review Comment:
we dont need to pin hawkeye since we already pin taiki itself
##########
licenserc.toml:
##########
@@ -16,28 +14,15 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-#
-
-RAT_VERSION=0.13
-
-# download apache rat
-if [ ! -f apache-rat-${RAT_VERSION}.jar ]; then
- curl -s
https://repo1.maven.org/maven2/org/apache/rat/apache-rat/${RAT_VERSION}/apache-rat-${RAT_VERSION}.jar
> apache-rat-${RAT_VERSION}.jar
-fi
-
-RAT="java -jar apache-rat-${RAT_VERSION}.jar -x "
-
-RELEASE_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
-# generate the rat report
-$RAT $1 > rat.txt
-python $RELEASE_DIR/check-rat-report.py $RELEASE_DIR/rat_exclude_files.txt
rat.txt > filtered_rat.txt
-cat filtered_rat.txt
-UNAPPROVED=`cat filtered_rat.txt | grep "NOT APPROVED" | wc -l`
+[header]
+builtin = "Apache-2.0-ASF"
-if [ "0" -eq "${UNAPPROVED}" ]; then
- echo "No unapproved licenses"
-else
- echo "${UNAPPROVED} unapproved licences. Check rat report: rat.txt"
- exit 1
-fi
+[files]
+includes = ["*.rs", "*.py"]
Review Comment:
i do wonder about limiting to rs and py files; is this preserving the
existing behaviour? what about md, toml, sh files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
