adamreeve commented on PR #11610: URL: https://github.com/apache/arrow-rs/pull/11610#issuecomment-6254771894
> I don't really know how to test this other than to make a release candidate, so I think we can do so when preparing for the next release Yeah I tested a `create-tarball.sh` followed by `verify-release-candidate.sh` with some of the external services mocked out (gpg, svn, serving the RC source). Which caught a problem when a submodule pointed to a commit from a PR rather than a branch (62281cd22e06bfdac07b091e4e4b9597cd0ec13e). But I don't think there's a way to fully test this end-to-end without an actual RC. > I wonder at this, as it seems the more natural approach 🤔 I guess we could add a custom field to the `.gitmodules` file, but this would be a non-standard use of it, which might be surprising if anybody is using that file for anything. I tested adding something extra in there and then git operations like `git status` failed with an error: `fatal: bad config line 4 in file /home/adam/dev/arrow-rs/.gitmodules`. I don't expect anyone would be using the source tarball as a git repository, but it seems safer to me to just use a separate file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
