AlenkaF commented on PR #55264: URL: https://github.com/apache/arrow/pull/55264#issuecomment-6434881325
Thanks for continuing to push this forward Rok! I think this PR is a great next step and is quite clear to review. I have checked out the PR locally and started with running type checkers (`mypy`, `pyright` and `ty`). `mypy` and `ty` emit no errors or warnings, but `pyright` does emit `reportMissingImports` and `reportMissingModuleSource` which get fixed with adding `_compute.pyi` placeholder (similar to existing `io.pyi`) and `reportMissingModuleSource = false` under `[tool.pyright]` in `pyproject.toml`. The reason for these warnings and errors in `pyright` is that locally I have editable pyarrow install where scikit-build-core puts the `.so` files in a separate folder (not python/pyarrow) without `__init__.py` and pyright can't find them. As we do not need the compiled modules for the type checkers, I think it is fine to use `reportMissingModuleSource = false`. I propose to push the changes directly if we agree the additions makes sense. Meanwhile I will continue with running the `pyarrow-stubs` tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
