lidavidm commented on code in PR #4963:
URL: https://github.com/apache/arrow-adbc/pull/4963#discussion_r4396761461
##########
go/adbc/drivermgr/wrapper_sqlite_test.go:
##########
@@ -588,6 +612,64 @@ func (dm *DriverMgrSuite) TestBindStream() {
dm.Truef(array.TableEqual(tableIn, tableOut), "expected: %s\ngot: %s",
tableIn, tableOut)
}
+// Run with ADBC_SQLITE_FLIGHTSQL_URI and the bundled Flight SQL driver
installed.
+func TestDriverMgrFlightSQLPartitions(t *testing.T) {
Review Comment:
If this won't run in CI and wasn't even checked locally, then remove the
test, or set it up properly and remove the comment.
##########
go/adbc/drivermgr/doc.go:
##########
Review Comment:
Why does the LLM really want to add to the doc comment here? IMO, none of
the PRs should add to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
