amoeba commented on code in PR #1431: URL: https://github.com/apache/arrow-go/pull/1431#discussion_r4404073296
########## arrow/compute/vector_sort.go: ########## @@ -206,6 +206,8 @@ func sortIndicesImpl(ctx context.Context, opts FunctionOptions, input Datum) (Da // SortIndices computes the indices that would sort the input. // For arrays and chunked arrays, pass a single SortKey (ColumnIndex is ignored). // For record batches and tables, pass []SortKey to specify multi-column sort order. +// Temporary sorting buffers use the context's allocator and are released before returning. +// The caller must release the returned datum. Review Comment: The related functions that wrap SortIndicies also inherit this requirement, should we update their docstrings as well? It's kind of a lot of places to update but they're all in the public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
