zeroshade commented on code in PR #1431: URL: https://github.com/apache/arrow-go/pull/1431#discussion_r4404906386
########## arrow/compute/vector_sort.go: ########## @@ -206,6 +206,8 @@ func sortIndicesImpl(ctx context.Context, opts FunctionOptions, input Datum) (Da // SortIndices computes the indices that would sort the input. // For arrays and chunked arrays, pass a single SortKey (ColumnIndex is ignored). // For record batches and tables, pass []SortKey to specify multi-column sort order. +// Temporary sorting buffers use the context's allocator and are released before returning. +// The caller must release the returned datum. Review Comment: Good point — done in e7578ba0. All nine public wrappers (`SortIndicesArray`/`Chunked`/`RecordBatch`/`Table`, `Sort`, `SortArray`, `SortChunked`, `SortRecordBatch`, `SortTable`) now say that, as with `SortIndices`, temporary sorting buffers use the context's allocator and are released before returning, and that the caller must release the returned value (naming the concrete return type). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
