bhaskargurram-ai commented on PR #11549: URL: https://github.com/apache/arrow-rs/pull/11549#issuecomment-6586294054
> Thanks @bhaskargurram-ai, the `try_new` shape with the Arrow type reads better than the earlier version. > > Could you update the PR description to match the head commit? It still describes the `visit_i32` / `visit_i64` / `visit_fixed_len_byte_array` extraction, which landed in #11741, and the docs table of converted types, which was removed. It also says `ArrowSbbf` is built from an `Sbbf` and a `ColumnDescriptor`, and that decimals of any precision can be passed to `check`. As I read [`check`](https://github.com/apache/arrow-rs/blob/04fdc52e641db7ada663772dd991950a5a327640/parquet/src/arrow/bloom_filter.rs#L162-L166), the array now has to have exactly the type given to `try_new`, and precision differences are handled only between that type and the column. Thanks @mbutrovich, good catch. Pushed 72ba948: try_new now compares the time unit of the Arrow type with the column's, so a TIMESTAMP(MILLIS) column rejects Timestamp(µs)/Timestamp(ns) and a TIME(MICROS) column rejects Time64(ns). Timestamp(Second) and Time32(Second) are written without a unit, so they're rejected against any column that has one. time_units_are_not_converted is now time_units_must_match and expects the errors. I also updated the PR description to match the current code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
