asuresh8 commented on PR #899:
URL:
https://github.com/apache/arrow-rs-object-store/pull/899#issuecomment-6584342096
+1 on this PR. I was about to submit a similar one.
This covers what we need, including the id-based path #863 leaves open. We
run an S3-compatible proxy that passes client multipart uploads through by
upload id, so complete_multipart_create is what keeps large objects create-only
for us. Sending the conditional completion once, signing If-None-Match, and
keeping a 409 ConditionalRequestConflict distinct from AlreadyExists are
exactly right. We read the full diff. Small things:
- The description says "tested on s3 and gcp", but nothing in the diff
touches GCS, which falls through to NotSupported. Worth clarifying.
- Nothing tests the S3ConditionalPut::Disabled refusal in set_put_mode and
complete_multipart_create.
- In LocalUpload, if the rename succeeds but the directory fsync fails, src
stays set, so a later abort or drop acts on a path that has already been
renamed away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
