HuaHuaY commented on PR #54059: URL: https://github.com/apache/arrow/pull/54059#issuecomment-6595945420
I’ve taken a quick look at the changes of `reader.cc` in the PR, and it seems to me that the approach is misguided. The original behavior—where `CSVBufferIterator` unconditionally consumes `\n`—was intended to handle cases without quotes, but it leads to incorrect behavior when encountered within a quoted field. I believe the right approach would be to remove this `\n`-consuming logic and instead ensure that `BlockReader` can correctly handle `\r\n` in unquoted contexts. What do you think, @pitrou? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
