pitrou commented on PR #54059: URL: https://github.com/apache/arrow/pull/54059#issuecomment-6633725684
> I’ve taken a quick look at the changes of `reader.cc` in the PR, and it seems to me that the approach is misguided. Agreed. This seems to basically duplicate CSV parsing out of the CSV parser. > I believe the right approach would be to remove this `\n`-consuming logic and instead ensure that `BlockReader` can correctly handle `\r\n` in unquoted contexts, The question is: how does it work when the unquoted `\r\n` straddles over two blocks? Also @AdityRajGupta please exercise judgement when pasting AI-generated code. Adding 500 lines of test code for a single bugfix is not reasonable. (the "Reviewed before submission" question is not just a checkbox to tick) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
