etseidl commented on code in PR #11877:
URL: https://github.com/apache/arrow-rs/pull/11877#discussion_r4464152713
##########
parquet/src/arrow/schema/extension.rs:
##########
@@ -129,19 +137,23 @@ pub(crate) fn has_extension_type(parquet_type: &Type) ->
bool {
/// files whose annotation does not carry version 1. The value written is
/// [`parquet_variant::VARIANT_SPEC_VERSION`], the same version stamped into
/// every metadata header.
-#[cfg(feature = "variant_experimental")]
+#[cfg(any(feature = "variant_experimental", feature = "file_experimental"))]
Review Comment:
Oh, good catch. I think the variant bits should be separately gated now.
Although reading it now, I wonder if that level of detail even belongs in the
docs 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
