etseidl commented on code in PR #11877:
URL: https://github.com/apache/arrow-rs/pull/11877#discussion_r4470754273
##########
parquet/src/arrow/schema/extension.rs:
##########
@@ -122,26 +130,28 @@ pub(crate) fn has_extension_type(parquet_type: &Type) ->
bool {
}
}
-/// Return the Parquet logical type to use for the specified Arrow Struct
field, if any.
-///
-/// The Parquet specification requires the `VARIANT` logical type annotation to
-/// carry the version number (`VARIANT(1)`); readers such as Apache Spark
reject
-/// files whose annotation does not carry version 1. The value written is
-/// [`parquet_variant::VARIANT_SPEC_VERSION`], the same version stamped into
-/// every metadata header.
-#[cfg(feature = "variant_experimental")]
+/// Return the Parquet logical type to use for the specified Arrow Struct
field, if any:
+/// `VARIANT` for the Variant extension type and `FILE` for `FileType`.
Review Comment:
Not going to delay any longer on this, but if we add a third extension I
think I'd not mention any return types here and instead enumerate them in the
module docstring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
