hcrosse commented on PR #1449: URL: https://github.com/apache/arrow-go/pull/1449#issuecomment-6638255055
@zeroshade Thanks. https://github.com/apache/arrow-go/pull/1457 fixes the `is_nan` panic by registering `is_nan`, `is_null` and `is_not_null` as plain `ScalarFunction`s instead of `compareFunction`s, so `is_nan` on a string or binary dictionary returns `arrow.ErrNotImplemented`. I added both cases to `TestDictionaryTypes` here. They panic until https://github.com/apache/arrow-go/pull/1457 merges, so this PR should merge after it. I left the `ExecuteScalarExpression` doc comment unchanged because I opened https://github.com/apache/arrow-go/pull/1461 to change that behavior. It makes `is_null` and `is_not_null` count a valid index pointing at a null dictionary value as null, matching Arrow C++. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
