hcrosse commented on PR #1449: URL: https://github.com/apache/arrow-go/pull/1449#issuecomment-6639595388
@zeroshade Thanks for the approval. I merged `main` now that https://github.com/apache/arrow-go/pull/1457 is in, and `TestDictionaryTypes` passes, including both `is_nan` dictionary cases. Switching the rejected loop to the checked `mem` makes the two `ErrInvalid` cases leak their input column, which is https://github.com/apache/arrow-go/issues/1450, so I left the loop on `memory.DefaultAllocator` here. With my fix for that issue applied, those cases pass on the checked allocator without leaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
