westonpace commented on a change in pull request #10258:
URL: https://github.com/apache/arrow/pull/10258#discussion_r643632152
##########
File path: cpp/src/arrow/util/future.h
##########
@@ -202,8 +202,30 @@ enum class FutureState : int8_t { PENDING, SUCCESS,
FAILURE };
inline bool IsFutureFinished(FutureState state) { return state !=
FutureState::PENDING; }
+/// \brief Describes whether the callback should be scheduled or run
synchronously
+enum ShouldSchedule {
+ /// Always run the callback synchronously (the default)
+ NEVER = 0,
Review comment:
Hmm, technically the style guide prefers `kAlways` but I see `Always`
used more often in Arrow. Although some of the gandiva code uses kAlways.
(https://google.github.io/styleguide/cppguide.html#Enumerator_Names). Any
preference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
