westonpace commented on a change in pull request #10258:
URL: https://github.com/apache/arrow/pull/10258#discussion_r643636029
##########
File path: cpp/src/arrow/util/test_common.h
##########
@@ -85,4 +88,18 @@ inline void AssertIteratorExhausted(Iterator<T>& it) {
Transformer<TestInt, TestStr> MakeFilter(std::function<bool(TestInt&)> filter);
+class MockExecutor : public internal::Executor {
Review comment:
There is a bit of categorization based on folder (e.g.
`util/test_common.h` vs `io/test_common.h`). This file isn't really all that
large. However, it could probably be split into `test_iterator_common.h` and
`test_thread_pool_common.h`. Or am I missing the point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
