Copilot commented on code in PR #1487:
URL: https://github.com/apache/arrow-go/pull/1487#discussion_r4514538139
##########
arrow/array/validate.go:
##########
@@ -143,7 +143,7 @@ func validateNullCount(data *Data) error {
}
var actualNulls int
- switch data.dtype.ID() {
+ switch storageType(data.dtype).ID() {
Review Comment:
Please add a regression test for an extension over null storage with a
positive length and a declared null count of 0. The new `MakeArrayOfNull` cases
always supply the correct count, and the existing mismatch test covers only
bitmap-backed Int32 storage, so neither protects this newly introduced
rejection. Construct the extension with `NewData`/`MakeFromData` and assert
that `Validate` succeeds while `ValidateFull` reports the null-count mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
