hcrosse commented on code in PR #1487:
URL: https://github.com/apache/arrow-go/pull/1487#discussion_r4515441143
##########
arrow/array/validate.go:
##########
@@ -93,7 +93,7 @@ func validateArray(arr arrow.Array, full bool, path string)
error {
if full && data.DataType().Layout().HasDict {
dictData := data.dictionary
if dictData != nil {
- dt := data.DataType().(*arrow.DictionaryType)
+ dt :=
storageType(data.DataType()).(*arrow.DictionaryType)
Review Comment:
Thanks for pointing this out. I left the index scan to the storage pass and
added `TestValidateFullExtensionOverDictionaryChecksIndices`. I kept the
extension's null count check because `null` storage resets its count to its
length, hiding a wrong count on the extension.
`TestValidateFullExtensionOverNullNullCountMismatch` covers that, and C++ also
checks the extension's own count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
