hcrosse opened a new pull request, #1541: URL: https://github.com/apache/arrow-go/pull/1541
### Rationale for this change `Validate` accepts missing binary values and panics on valid null REE scalars with primitive values. ### What changes are included in this PR? `validateOptional` takes a plain `bool` instead of inspecting an interface with reflection. REE validation checks that its validity matches its value's and runs type checks for null scalars too, matching Arrow C++ for these two checks. ### Are these changes tested? Corrected binary and string assertions check the intended scalar, and view tests require errors. `TestRunEndEncodedGetScalar` adds a null primitive run. `TestRunEndEncodedScalarValidateRejectsMismatches` covers validity mismatches and wrong or missing types. The new rows fail on main and pass with this change. With Go 1.26.10, vet, race tests on `arrow/scalar` and `arrow/compute`, full `go test -race -tags assert,test ./arrow/...` with pinned `arrow-testing` and `parquet-testing` checked out, `golangci-lint` 2.13.2 and the Release Audit Tool passed. ### Are there any user-facing changes? Yes. `Validate` returns errors for invalid scalars instead of passing or panicking, and accepts valid null REE scalars. There is no API change. Closes https://github.com/apache/arrow-go/issues/1536. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
