mohitgurav20 commented on code in PR #12148:
URL: https://github.com/apache/arrow-rs/pull/12148#discussion_r4561270194


##########
arrow-ipc/src/writer.rs:
##########
@@ -3143,6 +3208,133 @@ mod tests {
         }
     }
 
+    /// Batch exercising nulls, a dictionary column, and enough bytes that lz4 
emits several

Review Comment:
   Thanks for pointing this out. I updated the test to reuse one 
IpcWriteContext while switching block sizes. It checks that the output changes 
with the selected size and that each stream still round-trips. I also added the 
LZ4 specification link and simplified the comments you noted. I couldn’t run 
the test locally because link.exe is missing from my MSVC toolchain; I’ll share 
the result once it has run.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to