Rich-T-kid commented on code in PR #12148:
URL: https://github.com/apache/arrow-rs/pull/12148#discussion_r4620477111


##########
arrow-ipc/src/writer.rs:
##########
@@ -436,6 +446,53 @@ impl IpcWriteOptions {
         Ok(self)
     }
 
+    /// Configures the lz4 frame block size used when compressing batches with
+    /// [`crate::CompressionType::LZ4_FRAME`].
+    ///
+    /// `None` restores the default of 256 KiB, which balances compression 
throughput against the
+    /// buffers retained by the reusable encoder. The LZ4 frame header can 
only describe the
+    /// block sizes 64 KiB, 256 KiB, 1 MiB and 4 MiB; any other value returns 
an
+    /// [`ArrowError::InvalidArgumentError`]. Like the other compression 
settings this requires
+    /// metadata version V5 or newer, and it has no effect when another 
compression codec is
+    /// selected.

Review Comment:
   combining this with ZSTD returns an error



##########
arrow-ipc/src/writer.rs:
##########
@@ -27,7 +27,7 @@ use arrow_data::{ArrayData, ArrayDataBuilder, BufferSpec, 
layout};
 use arrow_schema::*;

Review Comment:
   nit: this does have a public facing change as there a new method, could you 
update the pr description



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to