hassaanch23 commented on PR #11144: URL: https://github.com/apache/arrow-rs/pull/11144#issuecomment-6853902164
I merged `main` now that #12161 is in. #12161 validates the dictionary reader's values with `StringArray::try_from_binary`, so this PR no longer touches `byte_array_dictionary.rs`. It now only covers the two non-dictionary readers, which makes it quite a bit smaller. I also shortened the comments and updated the description. `cargo test -p parquet --all-features` passes (2248 tests), and clippy with `-D warnings` is clean. With the four source files reverted to `main`, the new tests fail at the `offset_buffer.rs` panic. @alamb @Rich-T-kid, could you take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
