alamb commented on code in PR #11144:
URL: https://github.com/apache/arrow-rs/pull/11144#discussion_r4635490904
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -197,6 +204,10 @@ impl<I: OffsetSizeTrait> ColumnValueDecoder for
ByteArrayColumnValueDecoder<I> {
}
}
+ fn set_validate_utf8(&mut self, validate_utf8: bool) {
+ self.validate_utf8 |= validate_utf8;
Review Comment:
Sorry what I meant was that the rest of the crate doesn't follow this
pattern -- setters set the value to whatever was passed in, not `|=` to the
argument
for example
https://github.com/apache/arrow-rs/blob/b2e9bf5cac0b3534bfe1397b5594a41bc15c66c9/parquet/src/arrow/record_reader/mod.rs#L226-L228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]