CurtHagenlocher commented on PR #504:
URL: https://github.com/apache/arrow-dotnet/pull/504#issuecomment-6903665037

   Responses to the third Copilot review, which listed four issues in its 
summary without inline threads:
   
   - **Overlap checks reading `Span` (both buffer builders):** agreed, and 
fixed in 4a02294. It was broader than described: the first write after a build 
releases the builder's reference to the built buffer, so a span captured before 
`Build` could be read after release even without growth, because `CopyTo` 
evaluates `Span` first. The check now reads the builder's current memory 
without detaching, and copies the source first whenever writing could release 
that memory (growth, or memory handed to a built buffer). Covered by two new 
tests that use a poisoning pooled allocator.
   - **Decompression failures leak the output buffer:** agreed, fixed in 
4a02294. The output is now disposed if decompression throws or returns the 
wrong length. A new test reads corrupt compressed data through a caller-owned 
allocator and checks that nothing is left outstanding.
   - **`FlightSqlServer(ArrowContext?, ILoggerFactory?)` makes `base(null)` 
ambiguous:** I don't think this applies. The new overload has no optional 
parameters, so it isn't a candidate for a one-argument call; `base(null)` binds 
only to the existing `FlightSqlServer(ILoggerFactory? factory = null)`. I 
confirmed that a derived server calling `base(null)` (and `base()`) compiles 
without error.
   
   **On the earlier macOS `Verify` failure:** it wasn't caused by this PR, and 
a rerun passed. In the failing run, every project was restored under both 
`/var/folders/…` and `/private/var/folders/…` (on macOS, `/var` is a symlink to 
`/private/var`), so MSBuild treated each project as two and built them 
concurrently into the same outputs. Every passing run, including on `main`, 
uses `/private/var` only. The failure coincided with the newer runner image 
`20261103.629`, while the passing runs and the rerun were on `20261028.624`. So 
`main`'s macOS release verification may start failing the same way as that 
image rolls out. Resolving the temporary directory in 
`dev/release/verify_rc.sh` to a canonical path (for example with `pwd -P` after 
`mktemp`) should prevent it; I'll leave that to a separate change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to