CurtHagenlocher commented on PR #504: URL: https://github.com/apache/arrow-dotnet/pull/504#issuecomment-6906223999
The review on 34dc888 reported no open issues, but its summary mentioned a lifetime issue in `ArrowBuffer.Clone`. It's real, though narrow and older than this PR: `Clone` (and `Equals`) read the buffer through a span, which doesn't root the handle that owns the memory. So a buffer that is otherwise unreachable, with the default `Finalized` lifetime, could be finalized and its native memory freed partway through the copy. 399ab94 keeps the handle alive until the read finishes. Other lifetimes weren't affected, because they have no finalizer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
