Copilot commented on code in PR #55632:
URL: https://github.com/apache/arrow/pull/55632#discussion_r4585088686


##########
cpp/src/arrow/util/logging.h:
##########
@@ -189,9 +189,11 @@ class ARROW_EXPORT ArrowLog : public ArrowLogBase {
 
   /// Install the failure signal handler to output call stack when crash.
   /// If glog is not installed, this function won't do anything.
+  /// \deprecated Deprecated in 27.0.0. GLog support is deprecated.
   static void InstallFailureSignalHandler();
 
   /// Uninstall the signal actions installed by InstallFailureSignalHandler.
+  /// \deprecated Deprecated in 27.0.0. GLog support is deprecated.
   static void UninstallSignalAction();

Review Comment:
   The new `\deprecated` lines are Doxygen-only and do not mark either method 
as deprecated to the C++ compiler, so downstream callers will not receive the 
promised deprecation warnings. Add `ARROW_DEPRECATED("Deprecated in 27.0.0. 
GLog support is deprecated.")` before each declaration (and keep the 
suppression around the out-of-line definitions).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to