pitrou commented on code in PR #55632:
URL: https://github.com/apache/arrow/pull/55632#discussion_r4597165267
##########
cpp/src/arrow/flight/integration_tests/test_integration_client.cc:
##########
@@ -217,8 +217,6 @@ arrow::Status
RunScenario(arrow::flight::integration_tests::Scenario* scenario)
}
int main(int argc, char** argv) {
- arrow::util::ArrowLog::InstallFailureSignalHandler();
Review Comment:
Why not keep this while enclosing it in
`ARROW_SUPPRESS_DEPRECATION_WARNING` ?
##########
cpp/src/arrow/flight/integration_tests/test_integration_client.cc:
##########
@@ -217,8 +217,6 @@ arrow::Status
RunScenario(arrow::flight::integration_tests::Scenario* scenario)
}
int main(int argc, char** argv) {
- arrow::util::ArrowLog::InstallFailureSignalHandler();
Review Comment:
Why not keep this and other calls to deprecated APIs, while enclosing them
in `ARROW_SUPPRESS_DEPRECATION_WARNING` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]