alamb commented on code in PR #11144:
URL: https://github.com/apache/arrow-rs/pull/11144#discussion_r4635572222


##########
parquet/src/column/reader/decoder.rs:
##########
@@ -74,6 +74,11 @@ pub trait ColumnValueDecoder {
     /// Create a new [`ColumnValueDecoder`]
     fn new(col: &ColumnDescPtr) -> Self;
 
+    /// Validate decoded values as UTF-8 even if the column is not annotated 
as a string.
+    ///
+    /// Only turns validation on: a column annotated as a string is validated 
regardless.
+    fn set_validate_utf8(&mut self, _validate_utf8: bool) {}

Review Comment:
   this feels dangerous to me as it ignores set_validate_utf8 by default (as 
the default does nothing)



##########
parquet/src/column/reader/decoder.rs:
##########
@@ -74,6 +74,11 @@ pub trait ColumnValueDecoder {
     /// Create a new [`ColumnValueDecoder`]
     fn new(col: &ColumnDescPtr) -> Self;
 
+    /// Validate decoded values as UTF-8 even if the column is not annotated 
as a string.
+    ///
+    /// Only turns validation on: a column annotated as a string is validated 
regardless.
+    fn set_validate_utf8(&mut self, _validate_utf8: bool) {}

Review Comment:
   I will try and clean it up in a follow on



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to