benbellick commented on PR #1399: URL: https://github.com/apache/arrow-go/pull/1399#issuecomment-7023126707
Hey @zeroshade, small update! I wanted to see what it would look like to maintain multiple versions of the API on different underlying `substrait-go` versions. I have two attempts here: 1. Have a single source of truth on v9, with adapters for the v8 API ([benbellick#6](https://github.com/benbellick/arrow-go/pull/6)) 2. Maintain all of the duplicated code in both places ([benbellick#2](https://github.com/benbellick/arrow-go/pull/2)) (These are AI-generated and drafts, so I'm not asking for a real review here or anything, just sharing the general shape of the solutions.) As you can see, they both require quite a bit of code :sweat_smile:. Even if we reduce the scope of the expr API, the API surface is still quite large, and I think it will be a relatively large maintenance burden for Arrow maintainers. Instead, I took a stab at generating a PR that breaks this out into a separate module ([benbellick#7](https://github.com/benbellick/arrow-go/pull/7)), which to me seems a lot simpler ultimately. Like you suggested, it deprecates the existing package rather than moving it, and bumping the new module to `substrait-go` v9 would be a follow-up. We can version them separately, as we do in `substrait-go`. I'm unsure whether this is a reasonable goal to achieve before EOY for the next major release. Do you have any opinion on how we should move forward? Thanks a lot 🙇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
