zeroshade commented on PR #1399:
URL: https://github.com/apache/arrow-go/pull/1399#issuecomment-7051187339

   Thanks for putting those drafts together, that makes the trade-off a lot 
clearer. I agree the side-by-side versions are too much code to maintain, so 
let's go with the separate module.
   
   One thing I want to check before we commit to a major release: I don't think 
the separate module needs one. Go only compiles packages that are actually 
imported, so if the v9 code lives in the new module and `arrow/compute/exprs` 
stays on v8 as a deprecated package, anything that imports only the new module 
never builds the v8 code or `substrait-protobuf`. I tried it: a program that 
depends on arrow-go main without importing `exprs` compiles no 
`substrait-go/v8` packages and doesn't have the module in its binary. 
`substrait-go/v8` would still be listed in arrow-go's `go.mod`, but it would no 
longer constrain which `substrait-protobuf` you can build against, as long as 
iceberg-go moves to the new module. Does that cover your monorepo case, or is 
there something about the `go.mod` entry itself that still causes trouble?
   
   If that works, the plan would be:
   
   1. Merge #1500 (deprecations only).
   2. Add the new module, on v9 from the start if that's practical, and 
deprecate `arrow/compute/exprs` in place.
   3. Retarget this PR at the new module instead of `arrow/compute/exprs`.
   4. Leave #1627 and the removal of the old package for whenever the next 
major release happens, with no deadline attached.
   
   That takes the end-of-year pressure off. The part I still need to think 
through is the release process for a second module, since it would need its own 
tags and votes.
   
   @Sunyue the builder APIs you listed (`WrapLiteral`, `Cast`, `CallScalar`, 
`BuildExpr`) would stay where they are in `arrow/compute/exprs` until the next 
major release, and the new module would carry the same ones.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to