lichuang commented on PR #12353: URL: https://github.com/apache/arrow-rs/pull/12353#issuecomment-7036216202
Marking this as a draft for now. This PR currently bundles two things: the new `arrow-array/benches/builder_finish.rs` benchmark(https://github.com/apache/arrow-rs/pull/12356), and the builder changes that the benchmark measures. I'm moving the benchmark into a separate PR first. Without a `main` that already contains `builder_finish`, the automated benchmark runner has no baseline to compare against, so the bot can't measure this change — which is exactly the gap that was flagged on #12228. Once the benchmark PR is merged I'll rebase this branch, drop the benchmark from the diff, and mark it ready for review. The local numbers in the description will then be replaced by the bot run. Please hold off on reviewing until then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
