alamb commented on PR #12353: URL: https://github.com/apache/arrow-rs/pull/12353#issuecomment-7060771531
Update here is that I think we can approve this PR based on inspection rather than try to add a micro benchmark (see comments on https://github.com/apache/arrow-rs/pull/12356) So I suggest removing the benchmark and we can review/merge this as at least a nice code cleanup (and likely performance improvement) without obsessing about a micro benchmark for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
