Jimexist commented on a change in pull request #501:
URL: https://github.com/apache/arrow-datafusion/pull/501#discussion_r646554070
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -2761,15 +2765,24 @@ mod tests {
quick_test(sql, expected);
}
+ /// psql result
+ /// ```
+ /// QUERY PLAN
+ /// ----------------------------------------------------------------------
+ /// WindowAgg (cost=69.83..87.33 rows=1000 width=8)
+ /// -> Sort (cost=69.83..72.33 rows=1000 width=8)
+ /// Sort Key: order_id
+ /// -> Seq Scan on orders (cost=0.00..20.00 rows=1000 width=8)
+ /// ```
#[test]
- fn over_partition_by_not_supported() {
- let sql =
- "SELECT order_id, MAX(delivered) OVER (PARTITION BY order_id) from
orders";
- let err = logical_plan(sql).expect_err("query should have failed");
- assert_eq!(
- "NotImplemented(\"Unsupported OVER clause (PARTITION BY
order_id)\")",
- format!("{:?}", err)
- );
+ fn over_partition_by() {
+ let sql = "SELECT order_id, MAX(qty) OVER (PARTITION BY order_id) from
orders";
+ let expected = "\
+ Projection: #order_id, #MAX(qty)\
+ \n WindowAggr: windowExpr=[[MAX(#qty)]] partitionBy=[]\
Review comment:
Let me remove the list printing altogether for now to keep parity with
psql
I can always add it back later but for now the partition information is
already captured by the child sort by plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
